Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic

[Kunihiko Hayashi]

Hi Rob,

On 2022/12/08 0:35, Rob Herring wrote:
> On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote:
> > Add devicetree binding schema for the SoC-glue logic implemented on
> > Socionext Uniphier SoCs.
> >
> > This SoC-glue logic is a set of miscellaneous function registers
> > handling signals for specific devices outside system components,
> > and also has multiple functions such as I/O pinmux, usb-phy, debug,
> > clock-mux for a specific SoC, and so on.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---

(snip)

> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - socionext,uniphier-pro4-soc-glue
> > +              - socionext,uniphier-ld11-soc-glue
> > +    else:
> > +      patternProperties:
> > +        "^usb-hub(@[0-9a-f]+)?$": false
>
> While just if and else is valid json-schema, we require 'then'. Can you
> change this to 'if: { not: {...}, then: {}'.

I see. I'll rewrite it with invert condition.

> You should be getting a warning for this. The rest of the warnings from
> the bot look like false positives you can ignore.
Hmm, I couldn't see the warning for this condition.

The warnings your bot printed are the results evaluated before
applying the example fixes (PATCH 1-7) or before fixing the
existing devicetree (need to fix but yet).

Thank you,

---
Best Regards
Kunihiko Hayashi