Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller

From: Kunihiko Hayashi
Date: Thu Dec 08 2022 - 01:37:43 EST


On 2022/12/07 23:19, Rob Herring wrote:

On Wed, 07 Dec 2022 14:53:57 +0900, Kunihiko Hayashi wrote:
Add devicetree binding schema for the system controller implemented on
Socionext Uniphier SoCs.

This system controller has multiple functions such as clock control,
reset control, internal watchdog timer, thermal management, and so on.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
---
.../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 106 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.example.dtb:
sysctrl@61840000: 'thermal' does not match any of the regexes:
'^clock-controller(@[0-9a-f]+)?$', '^reset-controller(@[0-9a-f]+)?$',
'^thermal-sensor(@[0-9a-f]+)?$', '^watchdog(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml

doc reference errors (make refcheckdocs):

See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221207055405.30940-9-hayashi.kunihiko@xxxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your
schema.

Already confirmed with example fixes.
This warning is a result evaluated before applying PATCH 5.
[05/16] dt-bindings: thermal: Fix node descriptions in uniphier-thermal example

Thank you,

---
Best Regards
Kunihiko Hayashi