Re: [PATCH v2 15/16] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer

[Kunihiko Hayashi]

On 2022/12/08 17:23, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:54, Kunihiko Hayashi wrote:
> > Add DT binding schema for components belonging to the platform-specific
> > DWC3 USB glue layer implemented in UniPhier SoCs.
> >
> > This USB glue layer works as a sideband logic for the host controller,
> > including core reset, vbus control, PHYs, and some signals to the
> > controller.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   .../socionext,uniphier-dwc3-glue.yaml         | 106 ++++++++++++++++++
> >   1 file changed, 106 insertions(+)
> >   create mode 100644
> > Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> > new file mode 100644
> > index 000000000000..1b5585a5a3a2
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-dwc3-glue.yaml
> > @@ -0,0 +1,106 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/soc/socionext/socionext,uniphier-dwc3-glue.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Socionext UniPhier SoC DWC3 USB3.0 glue layer
> > +
> > +maintainers:
> > +  - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > +
> > +description: |+
> > +  DWC3 USB3.0 glue layer implemented on Socionext UniPhier SoCs is
> > +  a sideband logic handling signals to DWC3 host controller inside
> > +  USB3.0 component.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - socionext,uniphier-pro4-dwc3-glue
> > +          - socionext,uniphier-pro5-dwc3-glue
> > +          - socionext,uniphier-pxs2-dwc3-glue
> > +          - socionext,uniphier-ld20-dwc3-glue
> > +          - socionext,uniphier-pxs3-dwc3-glue
> > +          - socionext,uniphier-nx1-dwc3-glue
> > +      - const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#address-cells':
>
> Use consistent quotes - either ' or "

I'll change it.

> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> > +  ranges: true
> > +
> > +patternProperties:
> > +  "^reset-controller@[0-9a-f]+$":
> > +    $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
> > +
> > +  "^regulator@[0-9a-f]+$":
> > +    $ref: /schemas/regulator/socionext,uniphier-regulator.yaml#
> > +
> > +  "^phy@[0-9a-f]+$":
> > +    oneOf:
> > +      - $ref: /schemas/phy/socionext,uniphier-usb3hs-phy.yaml#
> > +      - $ref: /schemas/phy/socionext,uniphier-usb3ss-phy.yaml#
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
>
> You need to fix
> Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> example. I propose to drop usb-glue@65b00000 from that file. It's not
> relevant to that example.

I already fixed usb3-phy example in PATCH 6/16, however, it's better
to drop the parent node from the example not to avoid the effect of the changes.

Thank you,

---
Best Regards
Kunihiko Hayashi