Re: [PATCH v2 16/16] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer

[Kunihiko Hayashi]

On 2022/12/08 17:24, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:54, Kunihiko Hayashi wrote:
> > Add DT binding schema for components belonging to the platform-specific
> > AHCI glue layer implemented in UniPhier SoCs.
> >
> > This AHCI glue layer works as a sideband logic for the host controller,
> > including core reset, PHYs, and some signals to the controller.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   .../socionext,uniphier-ahci-glue.yaml         | 78 +++++++++++++++++++
> >   1 file changed, 78 insertions(+)
> >   create mode 100644
> > Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> > new file mode 100644
> > index 000000000000..bf37be8a778d
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-ahci-glue.yaml
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/soc/socionext/socionext,uniphier-ahci-glue.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Socionext UniPhier SoC AHCI glue layer
> > +
> > +maintainers:
> > +  - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > +
> > +description: |+
> > +  AHCI glue layer implemented on Socionext UniPhier SoCs is a sideband
> > +  logic handling signals to AHCI host controller inside AHCI component.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - socionext,uniphier-pro4-ahci-glue
> > +          - socionext,uniphier-pxs2-ahci-glue
> > +          - socionext,uniphier-pxs3-ahci-glue
> > +      - const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#address-cells':
>
> use consistent quotes

I'll change it.

> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> > +  ranges: true
> > +
> > +patternProperties:
> > +  "^reset-controller@[0-9a-f]+$":
> > +    $ref: /schemas/reset/socionext,uniphier-glue-reset.yaml#
> > +
> > +  "phy@[0-9a-f]+$":
> > +    $ref: /schemas/phy/socionext,uniphier-ahci-phy.yaml#
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties:
> > +  type: object
>
> What is the additional object? It's not in your example, not in DTS. Why
> do you need to allow it?

Sorry, I forgot to drop it. I'll replace it with:

   additionalProperties: false

Thank you,

---
Best Regards
Kunihiko Hayashi