Re: [PATCH 2/2] dt-bindings: display/panel: Add the focaltech gpt3

[Krzysztof Kozlowski]

On 13/12/2022 09:42, Christophe Branchereau wrote:
> Add bindings for the focaltech gpt3, which is a 640x480 3.0" 4:3
> IPS LCD Panel found in the YLM/Anbernic RG300X handheld.
> 
> Signed-off-by: Christophe Branchereau <cbranchereau@xxxxxxxxx>
> ---
>  .../display/panel/focaltech,gpt3.yaml         | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/focaltech,gpt3.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/focaltech,gpt3.yaml b/Documentation/devicetree/bindings/display/panel/focaltech,gpt3.yaml
> new file mode 100644
> index 000000000000..969f117c51ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/focaltech,gpt3.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/focaltech,gpt3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Focaltech GPT3 3.0" (640x480 pixels) IPS LCD panel
> +
> +maintainers:
> +  - Christophe Branchereau <cbranchereau>

That's not a correct email address.

> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: focaltech,gpt3
> +
> +  backlight: true
> +  port: true
> +  power-supply: true

Drop all three - provided by panel-common.yaml

> +  reg: true

maxItems: 1

(or from which other schema does it come?)

> +  reset-gpios: true


Drop - provided by panel-common.yaml

> +
> +required:
> +  - compatible
> +  - reg
> +  - power-supply
> +  - reset-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "focaltech,gpt3";
> +            reg = <0>;
> +
> +            spi-max-frequency = <3125000>;
> +
> +            reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> +
> +            backlight = <&backlight>;
> +            power-supply = <&vcc>;
> +
> +            port {
> +                panel_input: endpoint {
> +                    remote-endpoint = <&panel_output>;
> +                };
> +            };
> +        };
> +    };

Best regards,
Krzysztof