Re: [PATCH] ARM: dts: n900: switch accelerometer to iio driver

From: Sicelo
Date: Wed Dec 28 2022 - 05:28:57 EST


Thank you for the review.

> > + lis302dl: lis302dl@1d {
>
> That's not really explained in commit msg and does not look related to
> your goal. If changing - in separate patch - make the node name generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Now I understand that it should just be `accelerometer@1d`. To be clear,
are you saying this change should have a separate patch, i.e. not part
of the switch to iio driver?

> > - Vdd-supply = <&vaux1>;
> > - Vdd_IO-supply = <&vio>;
> > + vdd-supply = <&vaux1>;
> > + vddio-supply = <&vio>;
>
> Does not look related/explained in commit msg.

This is from Documentation/devicetree/bindings/iio/st,st-sensors.yaml,
i.e. lowercase. I will look for a way to explain it in v2.

Sincerely
Sicelo