Re: [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller

From: Krzysztof Kozlowski
Date: Wed Dec 28 2022 - 10:08:21 EST


On 28/12/2022 11:03, Anand Moon wrote:
> Add usb hub device id for Genesys Logic, Inc. GL852G-OHG Hub USB 2.0
> root hub and Genesys Logic, Inc. GL3523-QFN76 USB 3.1 root hub.
>
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index a9f831448cca..db009f3ef438 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -16,6 +16,8 @@ properties:
> compatible:
> enum:
> - usb5e3,608
> + - genesys,usb5e3,610
> + - genesys,usb5e3,620

This does not look like correct compatible. Did you test the bindings
and DTS? This should fail.

Best regards,
Krzysztof