Re: [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub

[Krzysztof Kozlowski]

On 28/12/2022 11:03, Anand Moon wrote:
> On Odroid c1 previously use gpio-hog to reset the usb hub,
> switch to used on board usb hub reset to enable the usb hub
> and enable power to usb hub.
> 
> Add usb hub regulator as per the schematic.
> 
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/meson8b-odroidc1.dts | 40 +++++++++++++++++---------
>  1 file changed, 27 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 04356bc639fa..3b29169aac43 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -185,6 +185,33 @@ vdd_rtc: regulator-vdd-rtc {
>  
>  		vin-supply = <&vcc_3v3>;
>  	};
> +
> +	usb_otg_pwr: regulator-usb-pwrs {
> +		compatible = "regulator-fixed";
> +		regulator-name = "USB_OTG_PWR";
> +
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +
> +		/* signal name from schematics: PWREN */
> +		gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		vin-supply = <&p5v0>;
> +	};
> +
> +	usb {
> +		dr_mode = "host";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		hub@1 {
> +			/* Genesys Logic GL852G-OHG usb hub */
> +			compatible = "genesys,usb5e3,610";

Wrong compatible. Does not match pattern in usb-device.yaml.


Best regards,
Krzysztof