Re: [PATCH] Documentation: Avoid duplicate Kconfig inclusion

From: Jonathan Corbet
Date: Sat Jan 14 2023 - 11:25:30 EST


Peter Foley <pefoley2@xxxxxxxxxxx> writes:

> Documentation/Kconfig is already included from lib/Kconfig.debug, avoid
> including it again and polluting the top-level menu.
>
> Signed-off-by: Peter Foley <pefoley2@xxxxxxxxxxx>
> ---
> Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 745bc773f5670..97ed6389c9211 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -28,5 +28,3 @@ source "crypto/Kconfig"
> source "lib/Kconfig"
>
> source "lib/Kconfig.debug"
> -
> -source "Documentation/Kconfig"
>

The duplicate inclusion does seem worth fixing, but I wonder if you're
deleting the right one? Having the documentation Kconfig under lib
seems a bit strange, somehow; Documentation/ is a top-level directory,
after all.

Thanks,

jon