Re: [PATCH net-next 1/1] drivers/phylib: fix coverity issue

[Jakub Kicinski]

On Tue, 17 Jan 2023 22:47:53 +0100 Piergiorgio Beruto wrote:
> Subject: [PATCH net-next 1/1] drivers/phylib: fix coverity issue

The title of the patch should refer to the bug rather than which tool
found it.

here, for eaxmple:

  net: phy: fix use of uninit variable when setting PLCA config

> Coverity reported the following:
> 
> *** CID 1530573:    (UNINIT)
> drivers/net/phy/phy-c45.c:1036 in genphy_c45_plca_set_cfg()
> 1030     				return ret;
> 1031
> 1032     			val = ret;
> 1033     		}
> 1034
> 1035     		if (plca_cfg->node_cnt >= 0)
[snip]
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@xxxxxxxxx>
> Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
> Addresses-Coverity-ID: 1530573 ("UNINIT")
> Fixes: 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration")

nit: the tags are in somewhat unnatural order. Since you'll need to
respin for the subject change, this would be better:

Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
Fixes: 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration")
Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@xxxxxxxxx>

(Yes, the custom coverity tag can go meet its friends in the bin)