Re: [PATCH 1/1] wifi: ath9k: hif_usb: fix memory leak of remain_skbs

[Fedor Pchelkin]

On 16.02.2023 21:05, Toke Høiland-Jørgensen wrote:
> Fedor Pchelkin <pchelkin@xxxxxxxxx> writes:
>
> > On 16.02.2023 19:15, Toke Høiland-Jørgensen wrote:
> >   > Erm, does this actually fix the leak? AFAICT, ath9k_hif_usb_dev_deinit()
> >   > is only called on the error path of ath9k_hif_usb_firmware_cb(), not
> >   > when the device is subsequently torn down in
> >   > ath9k_htc_disconnect_device()?
> >
> > ath9k_hif_usb_dev_deinit() is also called inside
> > ath9k_hif_usb_disconnect().
> No it's not, as of:
>
> f099c5c9e2ba ("wifi: ath9k: Fix use-after-free in ath9k_hif_usb_disconnect()")
>
> I guess you're looking at an older tree? Please base your patches on an
> up-to-date ath-next tree.
Oops, that's my fault, I indeed patched the wrong tree.

Thanks for clarifying!