Re: [PATCH v10 2/6] dt-bindings: opp: v2-qcom-level: Document CPR3 open/closed loop volt adjustment

From: Rob Herring
Date: Fri Feb 17 2023 - 18:14:46 EST


On Fri, Feb 17, 2023 at 12:08:25PM +0100, Konrad Dybcio wrote:
> CPR3 and newer can be fed per-OPP voltage adjustment values for both
> open- and closed-loop paths to make better decisions about settling
> on the final voltage offset target. Document these properties.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> .../devicetree/bindings/opp/opp-v2-qcom-level.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> index a30ef93213c0..93cc88434dfe 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> @@ -34,6 +34,20 @@ patternProperties:
> minItems: 1
> maxItems: 2
>
> + qcom,opp-cloop-vadj:
> + description: |
> + A value representing the closed-loop voltage adjustment value

A value?

> + associated with this OPP node.
> + $ref: /schemas/types.yaml#/definitions/int32-array
> + maxItems: 2

Or 2 values?

> +
> + qcom,opp-oloop-vadj:
> + description: |
> + A value representing the open-loop voltage adjustment value
> + associated with this OPP node.
> + $ref: /schemas/types.yaml#/definitions/int32-array
> + maxItems: 2
> +
> required:
> - opp-level
> - qcom,opp-fuse-level
>
> --
> 2.39.1
>