Re: [PATCH v2 5/9] coresight-tpdm: Add nodes to set trigger timestamp and type

[Tao Zhang]

Hi Suzuki,

在 2/28/2023 7:29 PM, Suzuki K Poulose 写道:
> On 19/01/2023 07:41, Tao Zhang wrote:
> > The nodes are needed to set or show the trigger timestamp and
> > trigger type. This change is to add these nodes to achieve these
> > function.
> >
> > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > Signed-off-by: Tao Zhang <taozha@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/coresight-tpdm.c | 97 
> > ++++++++++++++++++++++++++++
> >   1 file changed, 97 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c 
> > b/drivers/hwtracing/coresight/coresight-tpdm.c
> > index c29d667d..1dbb6c4 100644
> > --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> > @@ -20,6 +20,22 @@
> >     DEFINE_CORESIGHT_DEVLIST(tpdm_devs, "tpdm");
> >   +static umode_t tpdm_dsb_is_visible(struct kobject *kobj,
> > +                            struct attribute *attr, int n)
> > +{
> > +    struct device *dev = kobj_to_dev(kobj);
> > +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > +
> > +    if (drvdata) {
> > +        if (drvdata->datasets & TPDM_PIDR0_DS_DSB)
> > +            return attr->mode;
> > +        else
> > +            return 0;
> > +    }
>
>     if (drvdata && drvdata->dsb)
>         return attr->mode;
>
>     return 0;
>
> ?
Sure, I will update this in the next version of patch.
> > +
> > +    return 0;
> > +}
> > +
> >   static void tpdm_enable_dsb(struct tpdm_drvdata *drvdata)
> >   {
> >       u32 val;
> > @@ -241,8 +257,89 @@ static struct attribute_group tpdm_attr_grp = {
> >       .attrs = tpdm_attrs,
> >   };
> >   +static ssize_t dsb_trig_type_show(struct device *dev,
> > +                     struct device_attribute *attr,
> > +                     char *buf)
> > +{
> > +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > +
> > +    return sysfs_emit(buf, "%u\n",
> > +             (unsigned int)drvdata->dsb->trig_type);
> > +}
> > +
> > +/*
> > + * value 0: set trigger type as enablement
> > + * value 1: set trigger type as disablement
> > + */
> > +static ssize_t dsb_trig_type_store(struct device *dev,
> > +                      struct device_attribute *attr,
> > +                      const char *buf,
> > +                      size_t size)
> > +{
> > +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > +    unsigned long val;
> > +
> > +    if ((kstrtoul(buf, 0, &val)) || val < 0 || val > 1)
>
> val < 0 check here doesn't help on an unsigned variable.
>
> may be (val & ~1UL) ?
Sure, I will update this in the next version of the patch.
> > +        return -EINVAL;
> > +
> > +    spin_lock(&drvdata->spinlock);
> > +    if (val)
> > +        drvdata->dsb->trig_type = true;
> > +    else
> > +        drvdata->dsb->trig_type = false;
> > +    spin_unlock(&drvdata->spinlock);
> > +    return size;
> > +}
> > +static DEVICE_ATTR_RW(dsb_trig_type);
> > +
> > +static ssize_t dsb_trig_ts_show(struct device *dev,
> > +                     struct device_attribute *attr,
> > +                     char *buf)
> > +{
> > +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > +
> > +    return sysfs_emit(buf, "%u\n",
> > +             (unsigned int)drvdata->dsb->trig_ts);
> > +}
> > +
> > +/*
> > + * value 0: set trigger timestamp as enablement
> > + * value 1: set trigger timestamp as disablement
> > + */
> > +static ssize_t dsb_trig_ts_store(struct device *dev,
> > +                      struct device_attribute *attr,
> > +                      const char *buf,
> > +                      size_t size)
> > +{
> > +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> > +    unsigned long val;
> > +
> > +    if ((kstrtoul(buf, 0, &val)) || val < 0 || val > 1)
>
> same here.
>
> > +        return -EINVAL;
> > +
> > +    spin_lock(&drvdata->spinlock);
> > +    if (val)
> > +        drvdata->dsb->trig_ts = true;
> > +    else
> > +        drvdata->dsb->trig_ts = false;
> > +    spin_unlock(&drvdata->spinlock);
> > +    return size;
> > +}
> > +static DEVICE_ATTR_RW(dsb_trig_ts);
> > +static struct attribute *tpdm_dsb_attrs[] = {
> > +    &dev_attr_dsb_trig_ts.attr,
> > +    &dev_attr_dsb_trig_type.attr,
> > +    NULL,
> > +};
> > +
> > +static struct attribute_group tpdm_dsb_attr_grp = {
> > +    .attrs = tpdm_dsb_attrs,
> > +    .is_visible = tpdm_dsb_is_visible,
> > +};
> > +
> >   static const struct attribute_group *tpdm_attr_grps[] = {
> >       &tpdm_attr_grp,
> > +    &tpdm_dsb_attr_grp,
> >       NULL,
> >   };
>
> Suzuki
Best,

Tao