Re: [PATCH v2 5/9] coresight-tpdm: Add nodes to set trigger timestamp and type

[Tao Zhang]

Hi Suzuki,

在 2/28/2023 7:32 PM, Suzuki K Poulose 写道:
> On 19/01/2023 07:41, Tao Zhang wrote:
> > The nodes are needed to set or show the trigger timestamp and
> > trigger type. This change is to add these nodes to achieve these
> > function.
> >
> > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > Signed-off-by: Tao Zhang <taozha@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/coresight-tpdm.c | 97 
> > ++++++++++++++++++++++++++++
> >   1 file changed, 97 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c 
> > b/drivers/hwtracing/coresight/coresight-tpdm.c
> > index c29d667d..1dbb6c4 100644
> > --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> > @@ -20,6 +20,22 @@
>
>
> > +static struct attribute *tpdm_dsb_attrs[] = {
> > +    &dev_attr_dsb_trig_ts.attr,
> > +    &dev_attr_dsb_trig_type.attr,
> > +    NULL,
> > +};
> > +
> > +static struct attribute_group tpdm_dsb_attr_grp = {
> > +    .attrs = tpdm_dsb_attrs,
> > +    .is_visible = tpdm_dsb_is_visible,
> > +};
> > +
> >   static const struct attribute_group *tpdm_attr_grps[] = {
> >       &tpdm_attr_grp,
> > +    &tpdm_dsb_attr_grp,
> >       NULL,
> >   };
>
>
> Please also add documentation of the new sysfs handles under :
>
> Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm*
Sure, I will add the descriptions of new sysfs in the next of patch series.
> Suzuki
Best,

Tao