Re: [PATCH v4 0/3] Migrate the PCIe-IDIO-24 and WS16C48 GPIO drivers to the regmap API
From: Andy Shevchenko
Date: Mon Mar 06 2023 - 09:27:32 EST
On Mon, Mar 06, 2023 at 07:59:50AM -0500, William Breathitt Gray wrote:
> Changes in v4:
> - Allocate idio24gpio before using it in idio_24_probe()
> Changes in v3:
> - Drop map from set_type_config() parameter list; regmap can be passed
> by irq_drv_data instead
> - Adjust idio_24_set_type_config() for parameter list
> - Add mutex to prevent clobbering the COS_ENABLE register when masking
> IRQ and setting their type configuration
> Changes in v2:
> - Simplify PCIe-IDIO-24 register offset defines to remove superfluous
> arithmetic
> - Check for NULL pointer after chip->irq_drv_data allocation
> - Set gpio_regmap drvdata and use gpio_regmap_get_drvdata() to get the
> regmap in idio_24_reg_map_xlate()
>
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver.
>
> A patch to pass irq_drv_data as a parameter for struct regmap_irq_chip
> set_type_config() is included. This is needed by the
> idio_24_set_type_config() and ws16c48_set_type_config() callbacks in
> order to update the type configuration on their respective devices.
>
> A patch to migrate the WS16C48 GPIO driver to the regmap API is included
> in this series due to its dependence on the struct regmap_irq_chip
> set_type_config() change.
I have found nothing WRT lock type changes.
Can you shed a light on what's going on here?
--
With Best Regards,
Andy Shevchenko