Re: [PATCH v14 00/14] Add PSR support for eDP

From: Dmitry Baryshkov
Date: Tue Mar 07 2023 - 08:55:07 EST


David, Daniel & other drm maintainers,

On 02/03/2023 18:33, Vinod Polimera wrote:

[skipped the changelog]

Vinod Polimera (14):
drm: add helper functions to retrieve old and new crtc
drm/bridge: use atomic enable/disable callbacks for panel bridge
drm/bridge: add psr support for panel bridge callbacks

The first three patches are generic. How do we merge this series? I think these three patches should be merged into an immutable branch at drm-misc (or any other drm tree), which we can then merge into msm-next. What do you think?

drm/msm/disp/dpu: check for crtc enable rather than crtc active to
release shared resources
drm/msm/disp/dpu: get timing engine status from intf status register
drm/msm/disp/dpu: wait for extra vsync till timing engine status is
disabled
drm/msm/disp/dpu: reset the datapath after timing engine disable
drm/msm/dp: use atomic callbacks for DP bridge ops
drm/msm/dp: Add basic PSR support for eDP
drm/msm/dp: use the eDP bridge ops to validate eDP modes
drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder
functions
drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver
drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable
during self refresh
drm/msm/dp: set self refresh aware based on psr support

drivers/gpu/drm/bridge/panel.c | 68 +++++++-
drivers/gpu/drm/drm_atomic.c | 60 +++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 40 ++++-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 26 +++-
.../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 22 +++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 12 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
drivers/gpu/drm/msm/dp/dp_catalog.c | 80 ++++++++++
drivers/gpu/drm/msm/dp/dp_catalog.h | 4 +
drivers/gpu/drm/msm/dp/dp_ctrl.c | 80 ++++++++++
drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +
drivers/gpu/drm/msm/dp/dp_display.c | 36 +++--
drivers/gpu/drm/msm/dp/dp_display.h | 2 +
drivers/gpu/drm/msm/dp/dp_drm.c | 173 ++++++++++++++++++++-
drivers/gpu/drm/msm/dp/dp_drm.h | 9 +-
drivers/gpu/drm/msm/dp/dp_link.c | 36 +++++
drivers/gpu/drm/msm/dp/dp_panel.c | 22 +++
drivers/gpu/drm/msm/dp/dp_panel.h | 6 +
drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++
include/drm/drm_atomic.h | 7 +
22 files changed, 683 insertions(+), 43 deletions(-)


--
With best wishes
Dmitry