Re: [PATCH v1 1/2] dt-bindings: gpio: add fcs,fxl6408-gpio binding document

[Rob Herring]

On Mon, Mar 06, 2023 at 09:41:50AM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2023 09:34, Francesco Dolcini wrote:
> > From: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > 
> > Add binding document for Fairchild FXL6408 GPIO expander.
> 
> Subject: drop second/last, redundant "binding document". The
> "dt-bindings" prefix is already stating that these are bindings.
> 
> > 
> > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> 
> Missing SoB.
> 
> > ---
> >  .../bindings/gpio/fcs,fxl6408-gpio.yaml       | 73 +++++++++++++++++++

Also, match the compatible string here dropping '-gpio'.

> >  1 file changed, 73 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> > new file mode 100644
> > index 000000000000..ccf946040d00
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/fcs,fxl6408-gpio.yaml
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/fcs,fxl6408-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: FXL6408 GPIO driver
> 
> If "driver" means Linux driver, then drop.
> 
> Fairchild FXL6408 GPIO Expander
> 
> > +
> > +maintainers:
> > +  - Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > +
> > +description: |
> > +  Driver for Fairchild FXL6408 GPIO expander
> 
> This is not a driver. Drop entire description as it is duplicating title
> or add here something useful.
> 
> 
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fcs,fxl6408
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#gpio-cells":
> > +    const: 2
> > +
> > +  gpio-controller: true
> > +
> > +  gpio-line-names:
> > +    minItems: 1
> > +    maxItems: 8
> > +
> > +patternProperties:
> > +  "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> 
> >From here....
> 
> > +    type: object
> > +    properties:
> > +      gpio-hog: true
> > +      gpios: true
> > +      input: true
> > +      output-high: true
> > +      output-low: true
> > +      line-name: true
> > +
> > +    required:
> > +      - gpio-hog
> > +      - gpios
> > +
> > +    additionalProperties: false
> 
> To here, all this can be simpler:
> 
>   "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
>     required:
>       - gpio-hog
> 
> which selects gpio hog schema.
> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - gpio-controller
> > +  - "#gpio-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        gpio_expander_43: gpio-expander@43 {
> > +            compatible = "fcs,fxl6408";
> > +            gpio-controller;
> > +            #gpio-cells = <2>;
> > +            reg = <0x43>;
> > +            gpio-line-names = "Wi-Fi_W_DISABLE", "Wi-Fi_WKUP_WLAN",
> > +              "PWR_EN_+V3.3_WiFi_N", "PCIe_REF_CLK_EN",
> 
> Align with previous line/entries.
> 
> > +              "USB_RESET_N", "USB_BYPASS_N", "Wi-Fi_PDn",
> > +              "Wi-Fi_WKUP_BT";
> > +        };
> > +    };
> 
> Best regards,
> Krzysztof
>