Re: [RFC/PATCHSET 0/8] perf record: Implement BPF sample filter (v3)

[Namhyung Kim]

Hi Jiri,

On Tue, Mar 7, 2023 at 2:34 PM Jiri Olsa <olsajiri@xxxxxxxxx> wrote:
>
> On Wed, Feb 22, 2023 at 03:01:33PM -0800, Namhyung Kim wrote:
> > Hello,
> >
> > There have been requests for more sophisticated perf event sample
> > filtering based on the sample data.  Recently the kernel added BPF
> > programs can access perf sample data and this is the userspace part
> > to enable such a filtering.
> >
> > This still has some rough edges and needs more improvements.  But
> > I'd like to share the current work and get some feedback for the
> > directions and idea for further improvements.
> >
> > v3 changes)
> >  * fix build error on old kernels/vmlinux  (Arnaldo)
> >  * move the logic to evlist__apply_filters  (Jiri)
> >  * improve error message for bad input
>
> had same issue to compile it without BUILD_BPF_SKEL=1 as Adrian
> reported, but with that fixed it looks good
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Great!  Thanks for your review!

Namhyung