Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties

[Souradeep Chowdhury]

On 3/5/2023 6:29 PM, Krzysztof Kozlowski wrote:
> Nods with unit addresses must have also 'reg' property:

Nit: Should be "Nodes"

>    sc7280-herobrine-crd.dtb: eud@88e0000: ports:port@0: 'reg' is a required property
>
> Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>

>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..71179182c3b8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3593,12 +3593,17 @@ eud: eud@88e0000 {
>   			      <0 0x088e2000 0 0x1000>;
>   			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
>   			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>   				port@0 {
> +					reg = <0>;
>   					eud_ep: endpoint {
>   						remote-endpoint = <&usb2_role_switch>;
>   					};
>   				};
>   				port@1 {
> +					reg = <1>;
>   					eud_con: endpoint {
>   						remote-endpoint = <&con_eud>;
>   					};
> @@ -3609,7 +3614,11 @@ eud_con: endpoint {
>   		eud_typec: connector {
>   			compatible = "usb-c-connector";
>   			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>   				port@0 {
> +					reg = <0>;
>   					con_eud: endpoint {
>   						remote-endpoint = <&eud_con>;
>   					};