Re: [PATCH 1/2] fork: allow CLONE_NEWTIME in clone3 flags

From: Christian Brauner
Date: Wed Mar 08 2023 - 06:41:17 EST


From: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>


On Wed, 08 Mar 2023 11:51:26 +0100, Tobias Klauser wrote:
> Currently, calling clone3() with CLONE_NEWTIME in clone_args->flags
> fails with -EINVAL. This is because CLONE_NEWTIME intersects with
> CSIGNAL. However, CSIGNAL was deprecated when clone3 was introduced in
> commit 7f192e3cd316 ("fork: add clone3"), allowing re-use of that part
> of clone flags.
>
> Fix this by explicitly allowing CLONE_NEWTIME in clone3_args_valid. This
> is also in line with the respective check in check_unshare_flags which
> allow CLONE_NEWTIME for unshare().
>
> [...]

Thanks for fixing this. Applied, thanks! If someone has already picked this
up/prefers to carry it just let me know and I'll happily drop it,

[1/2] fork: allow CLONE_NEWTIME in clone3 flags
commit: a402f1e35313fc7ce2ca60f543c4402c2c7c3544
[2/2] selftests/clone3: test clone3 with CLONE_NEWTIME
commit: 515bddf0ec4155cbd666d72daf5bd68c8b7cd987

Thanks!
Christian