Re: [PATCH] mm: memory-failure: Move memory failure sysctls to its own file

[Kefeng Wang]

On 2023/3/9 13:14, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Thu, Mar 09, 2023 at 12:59:24PM +0800, Kefeng Wang wrote:
> > The sysctl_memory_failure_early_kill and memory_failure_recovery
> > are only used in memory-failure.c, move them to its own file.
>
> Thank you for the patch.
>
> Could you explain the benefit to move them?
> We seem to have many other parameters in kernel/sysctl.c which are used
> only in single places, so why do we handle these two differently?

Actually, all of them need to be moved into theirs own file as required
by proc sysctl maintainer, see [1]

> Thanks,
> Naoya Horiguchi

[1] https://lore.kernel.org/all/20211123202347.818157-1-mcgrof@xxxxxxxxxx/