Re: [PATCH] mm: memory-failure: Move memory failure sysctls to its own file

[HORIGUCHI NAOYA(堀口 直也)]

On Thu, Mar 09, 2023 at 02:03:39PM +0800, Kefeng Wang wrote:
> 
> 
> On 2023/3/9 13:14, HORIGUCHI NAOYA(堀口 直也) wrote:
> > On Thu, Mar 09, 2023 at 12:59:24PM +0800, Kefeng Wang wrote:
> > > The sysctl_memory_failure_early_kill and memory_failure_recovery
> > > are only used in memory-failure.c, move them to its own file.
> > 
> > Thank you for the patch.
> > 
> > Could you explain the benefit to move them?
> > We seem to have many other parameters in kernel/sysctl.c which are used
> > only in single places, so why do we handle these two differently?
> > 
> 
> Actually, all of them need to be moved into theirs own file as required
> by proc sysctl maintainer, see [1]

Thank you for clarification, so now I agree with the change.
It seems that checkpatch.pl shows the following error, so could
you resolve this?

  ERROR: do not initialise statics to 0
  #300: FILE: mm/memory-failure.c:70:
  +static int sysctl_memory_failure_early_kill __read_mostly = 0;

With this change, ...

Acked-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>

Thank you very much.