Re: [PATCH] dt-bindings: power: supply: bq256xx: Add ts-ignore property
From: Krzysztof Kozlowski
Date: Thu Mar 09 2023 - 05:13:23 EST
On 09/03/2023 03:39, Hermes Zhang wrote:
> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
> in chip. Ignore TS pin will allow user to control the charging
> parameters instead of the default JEITA profile in chip.
You miss users of it.
>
> Signed-off-by: Hermes Zhang <chenhuiz@xxxxxxxx>
> ---
> Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> index 82f382a7ffb3..74fd48f4bec5 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -68,6 +68,12 @@ properties:
> Interrupt sends an active low, 256 μs pulse to host to report the charger
> device status and faults.
>
> + ts-ignore:
Missing vendor prefix... is this generic property? ts-ignore is very
cryptic. You should describe here rather desired system characteristic.
Why anyone would need to use it per-board level?
> + type: boolean
> + description: |
> + If this property is set, the TS_IGNORE flag will be set to 1 which means
> + will not apply JEITA profile during the charging.> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof