Re: [PATCH v1 1/2] Add release hook to LSM

From: Andy Shevchenko
Date: Fri Mar 10 2023 - 15:14:18 EST


On Fri, Mar 10, 2023 at 09:02:18PM +0100, Mirsad Goran Todorovac wrote:
> On 10. 03. 2023. 20:47, Andy Shevchenko wrote:
> > On Fri, Mar 10, 2023 at 08:42:00PM +0100, Mirsad Goran Todorovac wrote:
> >>
> >> Add release() hook to the definition of the LSM modules, to enable calling
> >> destructors and deallocating allocated resources cleanly.
> >>
> >> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> >
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > I haven't given you this tag. Sorry, you must not add something
> > which was not explicitly given.

> This change could have long lasting consequences if approved, and I am not
> continuing the patch submission without your mentoring and approval.
>
> It is true that I assumed that you have reviewed the patch, but you did not
> explicitly give the Reviewed-by tag.
>
> But I am rather new to this patch submission process, and please would you
> please mentor me to do this the right way.

We have a nice documentation for that [1]. Please, read it in full.
If some questions left, do not hesitate to ask.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

--
With Best Regards,
Andy Shevchenko