Re: [PATCH v1 1/2] Add release hook to LSM
From: Andy Shevchenko
Date: Fri Mar 10 2023 - 15:12:51 EST
On Fri, Mar 10, 2023 at 08:52:32PM +0100, Mirsad Goran Todorovac wrote:
> On 10. 03. 2023. 20:47, Andy Shevchenko wrote:
> > On Fri, Mar 10, 2023 at 08:42:00PM +0100, Mirsad Goran Todorovac wrote:
> >>
> >> Add release() hook to the definition of the LSM modules, to enable calling
> >> destructors and deallocating allocated resources cleanly.
> >>
> >> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> >
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > I haven't given you this tag. Sorry, you must not add something
> > which was not explicitly given.
>
> Mea culpa.
>
> I misunderstood that you have approved the change when saying that I should
> file a formal patch. It worked with Florian Westphal in my first patch, so I
> thought it would be inappropriate to leave out who endorsed the patch.
We have Suggested-by tag for that.
> Thousand apologies. This is my second patch, so I am asking for some extra
> grace ...
> What should I do now?
Wait at least a couple of days (even more, since it's weekend) for other
comments and then send a v2 of the series with the comments addressed.
Btw, you may take my "smart" script [1] for sending patch series. It
makes much less headache on how to do that properly.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko