Re: [PATCH 3/5] i2c: xiic: hide OF related data for COMPILE_TEST

[Guenter Roeck]

On Sat, Mar 11, 2023 at 3:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
>   drivers/i2c/busses/i2c-xiic.c:1202:39: error: ‘xiic_2_00’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>

> ---
>  drivers/i2c/busses/i2c-xiic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..806b447055fb 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1199,11 +1199,11 @@ static const struct i2c_adapter xiic_adapter = {
>         .algo = &xiic_algorithm,
>  };
>
> +#if defined(CONFIG_OF)
>  static const struct xiic_version_data xiic_2_00 = {
>         .quirks = DYNAMIC_MODE_READ_BROKEN_BIT,
>  };
>
> -#if defined(CONFIG_OF)
>  static const struct of_device_id xiic_of_match[] = {
>         { .compatible = "xlnx,xps-iic-2.00.a", .data = &xiic_2_00 },
>         { .compatible = "xlnx,axi-iic-2.1", },
> --
> 2.34.1
>