Re: [PATCH 5/5] i2c: synquacer: mark OF related data as maybe unused

From: Guenter Roeck
Date: Sat Mar 11 2023 - 11:35:49 EST


On Sat, Mar 11, 2023 at 3:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/i2c/busses/i2c-synquacer.c:632:34: error: ‘synquacer_i2c_dt_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>

> ---
> drivers/i2c/busses/i2c-synquacer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index e4026c5416b1..50d19cf99a03 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -629,7 +629,7 @@ static int synquacer_i2c_remove(struct platform_device *pdev)
> return 0;
> };
>
> -static const struct of_device_id synquacer_i2c_dt_ids[] = {
> +static const struct of_device_id synquacer_i2c_dt_ids[] __maybe_unused = {
> { .compatible = "socionext,synquacer-i2c" },
> { /* sentinel */ }
> };
> --
> 2.34.1
>