Re: [PATCH] pata_parport: fix possible memory leak

[Ondrej Zary]

On Saturday 11 March 2023 21:23:25 Sergey Shtylyov wrote:
> On 3/11/23 11:19 PM, Sergei Shtylyov wrote:
> 
> >> When ida_alloc() fails, "pi" is not freed although the misleading
> >> comment says otherwise.
> >> Move the ida_alloc() call up so we really don't have to free it.
> 
>    Wait, but don't we still need to call kfree() in pi_init_one()?

If it fails at device_register, the dev.release is already set to pata_parport_dev_release which does the kfree(). put_device() should call it. If it fails later, device_unregister() should do it.
 
> >> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> >> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@xxxxxxxxx/
> >> Signed-off-by: Ondrej Zary <linux@xxxxxxx>
> > 
> > Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> > 
> > [...]
> 
> MBR, Sergey
> 


-- 
Ondrej Zary