Re: [PATCH] pata_parport: fix possible memory leak

[Sergey Shtylyov]

On 3/11/23 11:19 PM, Sergei Shtylyov wrote:

>> When ida_alloc() fails, "pi" is not freed although the misleading
>> comment says otherwise.
>> Move the ida_alloc() call up so we really don't have to free it.

   Wait, but don't we still need to call kfree() in pi_init_one()?

>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
>> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@xxxxxxxxx/
>> Signed-off-by: Ondrej Zary <linux@xxxxxxx>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> 
> [...]

MBR, Sergey