Re: [PATCH] pata_parport: fix possible memory leak

From: Sergei Shtylyov
Date: Sat Mar 11 2023 - 15:19:28 EST


On 3/11/23 9:51 PM, Ondrej Zary wrote:

> When ida_alloc() fails, "pi" is not freed although the misleading
> comment says otherwise.
> Move the ida_alloc() call up so we really don't have to free it.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@xxxxxxxxx/
> Signed-off-by: Ondrej Zary <linux@xxxxxxx>

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

[...]

MBR, Sergey