Re: [RFC PATCH v1] usb/phy add sprd ums512 usbphy

[Greg KH]

On Mon, Mar 13, 2023 at 01:14:38AM +0800, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
> 
> This driver is support USB2 phy for Spreadtrum UMS512 SOC's,
> 
> Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx>

Why is this "RFC"?  What is left to do on it to be accepted?

> ---
>  drivers/usb/phy/Kconfig           |  10 +
>  drivers/usb/phy/Makefile          |   1 +
>  drivers/usb/phy/phy-sprd-ums512.c | 511 ++++++++++++++++++++++++++++++
>  drivers/usb/phy/phy-sprd-ums512.h |  39 +++

Why do you need a .h file for a single .c file?  Please just put them
all together into one file.

thanks,

greg k-h