Re: [PATCH 1/9] regulator: lp872x: Mark OF related data as maybe unused

From: Mark Brown
Date: Mon Mar 13 2023 - 09:59:37 EST


On Fri, Mar 10, 2023 at 10:45:45PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/regulator/lp872x.c:931:34: error: ‘lp872x_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Here you're using maybe unused instead of removing the of_match_ptr()
(which does seem like a better approach). This really feels very
random, there's obviously a usability problem here.

Attachment: signature.asc
Description: PGP signature