Re: [PATCH 7/9] regulator: rpi-panel-attiny: Drop of_match_ptr for ID table

[Neil Armstrong]

On 10/03/2023 22:45, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).
>
>    drivers/regulator/rpi-panel-attiny-regulator.c:390:34: error: ‘attiny_dt_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>   drivers/regulator/rpi-panel-attiny-regulator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
> index 34514976475e..3953fc1f389f 100644
> --- a/drivers/regulator/rpi-panel-attiny-regulator.c
> +++ b/drivers/regulator/rpi-panel-attiny-regulator.c
> @@ -396,7 +396,7 @@ MODULE_DEVICE_TABLE(of, attiny_dt_ids);
>   static struct i2c_driver attiny_regulator_driver = {
>   	.driver = {
>   		.name = "rpi_touchscreen_attiny",
> -		.of_match_table = of_match_ptr(attiny_dt_ids),
> +		.of_match_table = attiny_dt_ids,
>   	},
>   	.probe_new = attiny_i2c_probe,
>   	.remove	= attiny_i2c_remove,


Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>