Re: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it

From: Christoph Hellwig
Date: Tue Mar 14 2023 - 13:31:49 EST


> -static long do_splice_to(struct file *in, loff_t *ppos,
> - struct pipe_inode_info *pipe, size_t len,
> - unsigned int flags)
> +long vfs_splice_read(struct file *in, loff_t *ppos,

The (pre-existing) long here is odd given that ->splice_read
returns a ssize_t. This might be a good time to fix that up.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>