Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE

From: Christoph Hellwig
Date: Tue Mar 14 2023 - 13:32:38 EST


On Wed, Mar 08, 2023 at 04:52:44PM +0000, David Howells wrote:
> Make generic_file_splice_read() use filemap_splice_read() and
> direct_splice_read() rather than using an ITER_PIPE and call_read_iter().
>
> Make cifs use generic_file_splice_read() rather than doing it for itself.

Please split the cifs patch out into a separate one.

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>