Re: [PATCH 17/28] media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table

[Jernej Škrabec]

Dne nedelja, 12. marec 2023 ob 14:13:07 CET je Krzysztof Kozlowski napisal(a):
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>   drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34:
> error: ‘sun6i_mipi_csi2_of_match’ defined but not used
> [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> 
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c index
> a220ce849b41..0851b6b4e1ff 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c
> @@ -759,7 +759,7 @@ static struct platform_driver
> sun6i_mipi_csi2_platform_driver = { .remove	= sun6i_mipi_csi2_remove,
>  	.driver	= {
>  		.name		= SUN6I_MIPI_CSI2_NAME,
> -		.of_match_table	= 
of_match_ptr(sun6i_mipi_csi2_of_match),
> +		.of_match_table	= sun6i_mipi_csi2_of_match,
>  		.pm		= &sun6i_mipi_csi2_pm_ops,
>  	},
>  };