Re: [PATCH 18/28] media: platform: sun8i-a83t-mipi-csi2: drop of_match_ptr for ID table

[Jernej Škrabec]

Dne nedelja, 12. marec 2023 ob 14:13:08 CET je Krzysztof Kozlowski napisal(a):
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>  
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:81
> 8:34: error: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used
> [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  .../platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> diff --git
> a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
> b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
> index cd2e92ae2293..1f0cc7b1ba47 100644
> ---
> a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
> +++
> b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
> @@ -826,7 +826,7 @@ static struct platform_driver
> sun8i_a83t_mipi_csi2_platform_driver = { .remove	=
> sun8i_a83t_mipi_csi2_remove,
>  	.driver	= {
>  		.name		= SUN8I_A83T_MIPI_CSI2_NAME,
> -		.of_match_table	= 
of_match_ptr(sun8i_a83t_mipi_csi2_of_match),
> +		.of_match_table	= sun8i_a83t_mipi_csi2_of_match,
>  		.pm		= &sun8i_a83t_mipi_csi2_pm_ops,
>  	},
>  };