Re: [PATCH v3 2/2] gpio: fxl6408: add I2C GPIO expander driver

[Bartosz Golaszewski]

On Mon, Mar 13, 2023 at 6:49 PM Francesco Dolcini <francesco@xxxxxxxxxx> wrote:
>
> On Mon, Mar 13, 2023 at 07:35:20PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 13, 2023 at 7:09 PM Francesco Dolcini <francesco@xxxxxxxxxx> wrote:
> > >
> > > From: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > >
> > > Add minimal driver for Fairchild FXL6408 8-bit I2C-controlled GPIO expander
> > > using the generic regmap based GPIO driver (GPIO_REGMAP).
> > >
> > > The driver implements setting the GPIO direction, reading inputs
> > > and writing outputs.
> > >
> > > In addition to that the FXL6408 has the following functionalities:
> > > - allows to monitor input ports for data transitions with an interrupt pin
> > > - all inputs can be configured with pull-up or pull-down resistors
> >
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> Thanks for the review, appreciated.
>
> > > +#include <linux/err.h>
> > > +#include <linux/gpio/regmap.h>
> > > +#include <linux/kernel.h>
> > > +#include <linux/i2c.h>
> >
> > Seems unordered?
>
> Whoops :-/
>
> Bartosz: if you or others have additional comments I'll change this for
> sure, if not up to you - please let me know.
>
> Francesco
>

I ordered them manually and applied the series.

Bart