Re: [PATCH 2/2] staging: vme_user: remove unnecessary blank lines

[Menna Mahmoud]

On ١٥‏/٣‏/٢٠٢٣ ١٥:١٩, Fabio M. De Francesco wrote:
> On mercoledì 15 marzo 2023 13:21:33 CET Menna Mahmoud wrote:
> > remove unnecessary blank lines before a close brace
> > as reported by checkpatch script
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> > +
> > +}
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> > +
> > +}
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> > +
> > +	}
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> > +
> > +}
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> > +
> > +}
> There are no valid reasons about copy-pasting that warning 5 times in a row.
> Just say that you get that message from checkpatch.pl in five different sites
> in the file you are changing.
>
> What if you had had 20 or 30 occurrences of that same "CHECK" in the same
> file?


yes, got your point. I will edit it.


Thanks,

Menna

> Thanks,
>
> Fabio
>
> > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>
> > ---
> >   drivers/staging/vme_user/vme_tsi148.c | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/staging/vme_user/vme_tsi148.c
> > b/drivers/staging/vme_user/vme_tsi148.c index bfa604043355..2f5eafd50934
> > 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.c
> > +++ b/drivers/staging/vme_user/vme_tsi148.c
> > @@ -1023,7 +1023,6 @@ static int tsi148_master_set(struct
> vme_master_resource
> > *image, int enabled, err_res:
> >   err_window:
> >   	return retval;
> > -
> >   }
> >
> >   /*
> > @@ -1741,7 +1740,6 @@ static int tsi148_dma_list_add(struct vme_dma_list
> > *list, list);
> >   		prev->descriptor.dnlau = cpu_to_be32(address_high);
> >   		prev->descriptor.dnlal = cpu_to_be32(address_low);
> > -
> >   	}
> >
> >   	return 0;
> > @@ -1773,7 +1771,6 @@ static int tsi148_dma_busy(struct vme_bridge
> > *tsi148_bridge, int channel) return 0;
> >   	else
> >   		return 1;
> > -
> >   }
> >
> >   /*
> > @@ -2220,7 +2217,6 @@ static int tsi148_crcsr_init(struct vme_bridge
> > *tsi148_bridge, }
> >
> >   	return 0;
> > -
> >   }
> >
> >   static void tsi148_crcsr_exit(struct vme_bridge *tsi148_bridge,
> > @@ -2530,7 +2526,6 @@ static int tsi148_probe(struct pci_dev *pdev, const
> > struct pci_device_id *id) kfree(tsi148_bridge);
> >   err_struct:
> >   	return retval;
> > -
> >   }
> >
> >   static void tsi148_remove(struct pci_dev *pdev)
> > --
> > 2.34.1