Re: [PATCH v3 3/3] staging: greybus: Inline pwm_chip_to_gb_pwm_chip()

From: Greg KH
Date: Sat Mar 25 2023 - 04:55:55 EST


On Sat, Mar 25, 2023 at 01:31:10AM -0700, Sumitra Sharma wrote:
> Convert 'pwm_chip_to_gb_pwm_chip' from a macro to a static
> inline function, to make the relevant types apparent in the
> definition and to benefit from the type checking performed by
> the compiler at call sites.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@xxxxxxxxx>
> ---
> drivers/staging/greybus/pwm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> index 3fda172239d2..88da1d796f13 100644
> --- a/drivers/staging/greybus/pwm.c
> +++ b/drivers/staging/greybus/pwm.c
> @@ -21,9 +21,11 @@ struct gb_pwm_chip {
> struct pwm_chip chip;
> struct pwm_chip *pwm;
> };
> -#define pwm_chip_to_gb_pwm_chip(chip) \
> - container_of(chip, struct gb_pwm_chip, chip)
>
> +static inline struct gb_pwm_chip *pwm_chip_to_gb_pwm_chip(struct pwm_chip *chip)
> +{
> + return container_of(chip, struct gb_pwm_chip, chip);
> +}
>
> static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
> {
> --
> 2.25.1
>
>

This patch didn't apply due to changes made in my tree by a patch from
someone else before yours. Can you rebase it and resend?

thanks,

greg k-h