Re: [PATCH 1/4] arm64: dts: msm8953: Replace xo_board with rpmcc sourced xo

[Konrad Dybcio]

On 25.03.2023 12:28, Adam Skladowski wrote:
> Assign RPM_SMD_XO_CLK_SRC from rpmcc in place
> of fixed-clock where possible.
> 
> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
>  arch/arm64/boot/dts/qcom/msm8953.dtsi | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> index da00c2f04cda..438a70eb6152 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> @@ -2,6 +2,7 @@
>  /* Copyright (c) 2022, The Linux Foundation. All rights reserved. */
>  
>  #include <dt-bindings/clock/qcom,gcc-msm8953.h>
> +#include <dt-bindings/clock/qcom,rpmcc.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/power/qcom-rpmpd.h>
> @@ -637,7 +638,7 @@ gcc: clock-controller@1800000 {
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;
> -			clocks = <&xo_board>,
> +			clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
>  				 <&sleep_clk>,
>  				 <0>,
>  				 <0>,
> @@ -801,7 +802,7 @@ dsi0_phy: phy@1a94400 {
>  				#clock-cells = <1>;
>  				#phy-cells = <0>;
>  
> -				clocks = <&gcc GCC_MDSS_AHB_CLK>, <&xo_board>;
> +				clocks = <&gcc GCC_MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>;
>  				clock-names = "iface", "ref";
>  
>  				status = "disabled";
> @@ -868,7 +869,7 @@ dsi1_phy: phy@1a96400 {
>  				#clock-cells = <1>;
>  				#phy-cells = <0>;
>  
> -				clocks = <&gcc GCC_MDSS_AHB_CLK>, <&xo_board>;
> +				clocks = <&gcc GCC_MDSS_AHB_CLK>, <&rpmcc RPM_SMD_XO_CLK_SRC>;
>  				clock-names = "iface", "ref";
>  
>  				status = "disabled";
> @@ -992,7 +993,7 @@ sdhc_1: mmc@7824900 {
>  
>  			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
>  				 <&gcc GCC_SDCC1_APPS_CLK>,
> -				 <&xo_board>;
> +				 <&rpmcc RPM_SMD_XO_CLK_SRC>;
>  			clock-names = "iface", "core", "xo";
>  
>  			power-domains = <&rpmpd MSM8953_VDDCX>;
> @@ -1052,7 +1053,7 @@ sdhc_2: mmc@7864900 {
>  
>  			clocks = <&gcc GCC_SDCC2_AHB_CLK>,
>  				 <&gcc GCC_SDCC2_APPS_CLK>,
> -				 <&xo_board>;
> +				 <&rpmcc RPM_SMD_XO_CLK_SRC>;
>  			clock-names = "iface", "core", "xo";
>  
>  			power-domains = <&rpmpd MSM8953_VDDCX>;