Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: add qcom,sdm845-slpi-pas compatible

[Krzysztof Kozlowski]

On 25/03/2023 14:21, Dylan Van Assche wrote:
> SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas'
> compatible in the qcom_q6v5_pas driver. Add this compatible to the
> devicetree bindings.
> 
> Signed-off-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 643ee787a81f..175be01ecd1c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -26,6 +26,7 @@ properties:
>        - qcom,sdm660-adsp-pas
>        - qcom,sdm845-adsp-pas
>        - qcom,sdm845-cdsp-pas
> +      - qcom,sdm845-slpi-pas
>  
>    reg:
>      maxItems: 1
> @@ -63,6 +64,7 @@ allOf:
>                - qcom,msm8998-adsp-pas
>                - qcom,sdm845-adsp-pas
>                - qcom,sdm845-cdsp-pas
> +              - qcom,sdm845-slpi-pas
>      then:
>        properties:
>          clocks:
> @@ -104,6 +106,7 @@ allOf:


You miss also if:then: for power-domains.

Best regards,
Krzysztof