Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: add qcom,assign-all-memory property

From: Krzysztof Kozlowski
Date: Sun Mar 26 2023 - 04:55:36 EST


On 25/03/2023 14:44, Dylan Van Assche wrote:
> Document the added qcom,assign-all-memory in devicetree bindings.
>
> Signed-off-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> index 1ab9588cdd89..fa5b00534b30 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> @@ -57,6 +57,12 @@ properties:
> Virtual machine IDs for remote processor.
> $ref: "/schemas/types.yaml#/definitions/uint32-array"
>
> + qcom,assign-all-mem:
> + description:
> + Assign memory to all Virtual machines defined by qcom,vmids.

This (neither commit msg) does not explain why this is needed and
actually does not sound like hardware-related property.

> + type: boolean
> +
> +

Do not add double blank lines.

> "#address-cells":
> const: 1
>

Best regards,
Krzysztof