Re: [PATCH v3 1/2] dt-bindings: spi: add loongson spi

From: Krzysztof Kozlowski
Date: Mon Mar 27 2023 - 04:56:36 EST


On 27/03/2023 10:39, zhuyinbo wrote:
>
>
> 在 2023/3/24 下午9:07, Rob Herring 写道:
>>
>> On Fri, 24 Mar 2023 14:33:16 +0800, Yinbo Zhu wrote:
>>> Add the Loongson platform spi binding with DT schema format using
>>> json-schema.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
>>> ---
>>> .../bindings/spi/loongson,ls-spi.yaml | 43 +++++++++++++++++++
>>> MAINTAINERS | 6 +++
>>> 2 files changed, 49 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
> Hi Rob Herring,
>
> This error was still appears on 22 line, this line was
> LOONGSON2_BOOT_CLK not refer, it need depend on
> https://lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@xxxxxxxxxxx/
> then compile will be successful. and I had added this depend on
> description in v2, v3 patch changelog, I was also send a email to remind
> your bot for the test my patch need dpend on other clock patch.

... and did you read Rob's advice? For some reason you responded to
automated bot's email, but not to actual email from Rob.

Best regards,
Krzysztof