Re: [PATCH v3 2/2] spi: loongson: add bus driver for the loongson spi controller

From: Krzysztof Kozlowski
Date: Mon Mar 27 2023 - 04:57:03 EST


On 27/03/2023 10:42, zhuyinbo wrote:
>
>
> 在 2023/3/24 下午7:31, Krzysztof Kozlowski 写道:
>> On 24/03/2023 07:33, Yinbo Zhu wrote:
>>> This bus driver supports the Loongson spi hardware controller in the
>>> Loongson platforms and supports to use DTS and PCI framework to
>>> register spi device resources.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
>>> ---
>>> MAINTAINERS | 4 +
>>> drivers/spi/Kconfig | 31 ++++
>>> drivers/spi/Makefile | 3 +
>>> drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>>> drivers/spi/spi-loongson-pci.c | 89 ++++++++++
>>> drivers/spi/spi-loongson-plat.c | 66 +++++++
>>> drivers/spi/spi-loongson.h | 41 +++++
>>> 7 files changed, 536 insertions(+)
>>> create mode 100644 drivers/spi/spi-loongson-core.c
>>> create mode 100644 drivers/spi/spi-loongson-pci.c
>>> create mode 100644 drivers/spi/spi-loongson-plat.c
>>> create mode 100644 drivers/spi/spi-loongson.h
>>
>> Your patches still have build warnings. Are these false postives or you
>> forgot to build it? Anyway, please respond to the report.
>>
>> Best regards,
>> Krzysztof
> thanks your reminder, I have already provided feedback about compile issue.

Then please test your patches before sending...

Best regards,
Krzysztof