Re: [PATCH v4 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY

[Varadarajan Narayanan]

On Mon, Mar 27, 2023 at 01:02:52PM +0300, Dmitry Baryshkov wrote:
> On 27/03/2023 12:30, Varadarajan Narayanan wrote:
> >Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574
> >
> >Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> >---
> >  Changes in v4:
> >	- Remove constraints not applicable to IPQ9574
> >  Changes in v3:
> >	- Update other mandatory fields to accomodate IPQ9574
> >  Changes in v2:
> >	- Updated sections missed in previous patch
> >---
> >  .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml    | 25 ++++++++++++++++++++--
> >  1 file changed, 23 insertions(+), 2 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> >index e81a382..aa5b58c 100644
> >--- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> >+++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> >@@ -21,6 +21,7 @@ properties:
> >      enum:
> >        - qcom,ipq6018-qmp-usb3-phy
> >        - qcom,ipq8074-qmp-usb3-phy
> >+      - qcom,ipq9574-qmp-usb3-phy
> >        - qcom,msm8996-qmp-usb3-phy
> >        - qcom,msm8998-qmp-usb3-phy
> >        - qcom,qcm2290-qmp-usb3-phy
> >@@ -122,8 +123,6 @@ required:
> >    - clock-names
> >    - resets
> >    - reset-names
> >-  - vdda-phy-supply
> >-  - vdda-pll-supply
>
> Same questions as for the qusb2 PHY. How is the PHY powered?

It is powered by always on regulators. Will create fixed
regulators and assign them to these.

Thanks
Varada

> >  additionalProperties: false
>
> --
> With best wishes
> Dmitry
>