Re: [PATCH] dt-bindings: watchdog: alphascale-asm9260: convert to DT schema

[Krzysztof Kozlowski]

On 03/04/2023 02:42, Om Parikh wrote:
> this patch replaces the txt file and adds YAML bindings file

Do not use "This commit/patch", but imperative mood. See:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Use full sentences, so start with capital letter.

> adhering to the json-schema for alphascale-asm9260. It is a
> demo patch for potential further contributions to the GSOC
> project.

Drop unrelated messages.

> 
> (see: https://wiki.linuxfoundation.org/gsoc/2023-gsoc-device-tree-bindings)

Drop, not related to Linux kernel.

Anyway, send your patches first through you mentor, so we won't have to
comment on trivial things.


Daniel,
Are you doing a review of your mentees?

> 
> Signed-off-by: Om Parikh <hack3r-0m@xxxxxxxxx>
> ---
>  .../watchdog/alphascale,asm9260-wdt.yaml      | 76 +++++++++++++++++++
>  .../bindings/watchdog/alphascale-asm9260.txt  | 35 ---------
>  2 files changed, 76 insertions(+), 35 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> new file mode 100644
> index 000000000000..1f7baaf6b0f3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/alphascale,asm9260-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Alphascale asm9260 Watchdog timer
> +
> +allOf:
> +  - $ref: "watchdog.yaml#"

Drop quotes.

> +
> +maintainers:
> +  - Oleksij Rempel <linux@xxxxxxxxxxxxxxxx>
> +  - Olof Johansson <olof@xxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - alphascale,asm9260
> +      - alphascale,asm9260devkit

NAK, this does not make any sense. I don't understand what do you want
to document here. These are boards.


Best regards,
Krzysztof