Re: [PATCH] dt-bindings: watchdog: alphascale-asm9260: convert to DT schema

From: Rob Herring
Date: Mon Apr 03 2023 - 09:10:36 EST



On Mon, 03 Apr 2023 00:42:35 +0000, Om Parikh wrote:
> this patch replaces the txt file and adds YAML bindings file
> adhering to the json-schema for alphascale-asm9260. It is a
> demo patch for potential further contributions to the GSOC
> project.
>
> (see: https://wiki.linuxfoundation.org/gsoc/2023-gsoc-device-tree-bindings)
>
> Signed-off-by: Om Parikh <hack3r-0m@xxxxxxxxx>
> ---
> .../watchdog/alphascale,asm9260-wdt.yaml | 76 +++++++++++++++++++
> .../bindings/watchdog/alphascale-asm9260.txt | 35 ---------
> 2 files changed, 76 insertions(+), 35 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.example.dtb: /example-0/watchdog@80048000: failed to match any schema with compatible: ['alphascale,asm9260-wdt']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230403004138.326482-1-hack3r-0m@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.