Re: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer

From: Vincent Whitchurch
Date: Mon Apr 03 2023 - 08:59:29 EST


On Mon, 2023-04-03 at 11:40 +0200, Krzysztof Kozlowski wrote:
> For a shared timers, the mct_init_dt() should not initialize the clock
> even with global comparator. This is not an error, thus the function
> should simply return 0, not 'ret'.
>
> This also fixes smatch warning:
>
>   drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@xxxxxxxxx/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>