RE: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for shared timer

[Alim Akhtar]

Hello Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, April 3, 2023 3:10 PM
> To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Thomas Gleixner
> <tglx@xxxxxxxxxxxxx>; Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx>;
> Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>; kernel test robot
> <lkp@xxxxxxxxx>; Dan Carpenter <error27@xxxxxxxxx>
> Subject: [PATCH] clocksource/drivers/exynos_mct: explicitly return 0 for
> shared timer
> 
> For a shared timers, the mct_init_dt() should not initialize the clock
even with
> global comparator.  This is not an error, thus the function should simply
> return 0, not 'ret'.
> 
> This also fixes smatch warning:
> 
>   drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error
> code? 'ret'
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@xxxxxxxxx/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

>  drivers/clocksource/exynos_mct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index bfd60093ee1c..ef8cb1b71be4 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -677,17 +677,17 @@ static int __init mct_init_dt(struct device_node
> *np, unsigned int int_type)
>  	if (ret)
>  		return ret;
> 
>  	/*
>  	 * When the FRC is shared with a main processor, this secondary
>  	 * processor cannot use the global comparator.
>  	 */
>  	if (frc_shared)
> -		return ret;
> +		return 0;
> 
>  	return exynos4_clockevent_init();
>  }
> 
> 
>  static int __init mct_init_spi(struct device_node *np)  {
>  	return mct_init_dt(np, MCT_INT_SPI);
> --
> 2.34.1